Changes News to Know to News #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeProgrammer88
requested changes
Nov 26, 2024
There was a problem hiding this comment.
The "News To Know" text on the Index view can be left alone since that text will only appear in the browser tab and on that page.
On the _Layout view, we want to change the text "News to Know" to just "News" in the navigation section. The issue has a screenshot of the text in the navigation itself to see where it is getting squished
|
That is what I was looking for! I totally forgot about the layout, I knew I
was missing something. Please allow me to fix it if you haven’t already
done so.
…On Tue, Nov 26, 2024 at 1:01 PM Joseph Ortiz ***@***.***> wrote:
***@***.**** requested changes on this pull request.
The "News To Know" text on the Index view can be left alone since that
text will only appear in the browser tab and on that page.
On the _Layout view, we want to change the text "News to Know" to just
"News" in the navigation section. The issue has a screenshot of the text in
the navigation itself to see where it is getting squished
------------------------------
In PC2/Views/NewsToKnow/Index.cshtml
<#348 (comment)>:
> @@ -2,7 +2,7 @@
<link rel="stylesheet" type="text/css" href="~/css/news.css" />
}
@{
- ViewData["Title"] = "News To Know";
We can leave this text as is on the page
—
Reply to this email directly, view it on GitHub
<#348 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BH4IU6QY2NE3BECAF5A5SVT2CTOSRAVCNFSM6AAAAABSPDEGP6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINRSGY3DCMZVHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@ElizabethK9 Yes, please fix it and I'll review it again when you push your changes up. Thanks! |
…l back from news to News to Know
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be News instead of News to Know, let me know if it's not then I can see if I did it incorrectly.